-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Poetry #4912
Comments
What would be the poetry workflow in read the docs? Pipfile support will be out soon btw. If this gets implemented, it would live as an option in the configuration file. |
locally i run although if there is a virtualenv already active then poetry will install the dependencies into that instead, which means it should work the same as for requirements.txt or Pipfile? |
My workflow is pretty similar:
Real project example that uses both |
So, replacing the |
@humitos yes, I think so. Mind, that we also have to work with |
if you have the venv active, you can run
|
Is there a use case where users only want to install dev/prod deps? There are any other configurations that users may want to set? |
the latter is more along the lines of you can also use full docs are at https://poetry.eustace.io/docs/cli/#install |
I think this problem will resolve itself once the next version of
to the |
except the build script runs |
@danielknell we do support installing the project using pip. @uSpike I have read the pip issue and pep, but I wasn't able to understand it very well yet :/ will this replace pipenv too? |
@stsewd pip might be able to install from a |
@danielknell - yeah, check here: https://docs.readthedocs.io/en/latest/yaml-config.html#python-pip-install, might be able to do it through the web config too. So, guess we're just waiting on pypa/pip#6106. @stsewd : once pip 0.19.0 is out, how long before it makes it into a readthedocs image that we can use? |
We install the latest version of pip before each build #4938, so it should be available after they release it :) |
I'm not very familiar with Python virtual environments, but there may be another issue there. I run poetry from a
|
Since new
ApplicationTrying:
LibraryTrying: |
does it work within rtfd? i keep meaning to try but have not found time to update my projects yet with the config to install via pip. |
@sobolevn I wouldn't expect https://github.com/wemake-services/wemake-django-template to install since it is a template (cookiecutter) project. |
@uSpike |
the fact it does not install dev dependencies is concerning and maybe pep 517 isn't enough to fully support poetry projects? |
I have also tried to research this |
that means |
Can anyone try a project in rtd? We have the latest pip installed, let us know if there is anything else to do from our side to support poetry. |
@sobolevn that project (https://github.com/wemake-services/wemake-django-template) is a template, you're not supposed to @danielknell aah I forgot about that... there might be a way to pass flags to poetry via pip? |
…to follow readthedocs/readthedocs.org#4912 (comment) which seems to be the recommended way. Previous method was using mkdocs version 1.1 for some reason. mkdocs version 1.1 doesn't work with the latest version of jinja2 (https://twitter.com/readthedocs/status/1507388916013314048).
…to follow readthedocs/readthedocs.org#4912 (comment) which seems to be the recommended way. Previous method was using mkdocs version 1.1 for some reason. mkdocs version 1.1 doesn't work with the latest version of jinja2 (https://twitter.com/readthedocs/status/1507388916013314048).
you may need to use this: version: 2
build:
os: "ubuntu-22.04"
tools:
python: "3.10"
jobs:
post_create_environment:
# Install poetry
# https://python-poetry.org/docs/#installing-manually
- python -m pip install poetry
post_install:
# Install dependencies with 'docs' dependency group
# https://python-poetry.org/docs/managing-dependencies/#dependency-groups
- VIRTUAL_ENV=$READTHEDOCS_VIRTUALENV_PATH poetry install --with docs
sphinx:
configuration: docs/conf.py |
More fonts Update .readthedocs.yml readthedocs/readthedocs.org#4912 (comment)
There was a problem with building documentation on the read-the docs server because it couldn't find the `sphinxcontrib-mermaid` library. The solution was found here: https://github.com/readthedocs/readthedocs.org/issues/4912\#issuecomment-1992286540
Update RTD config based on this command to (hopefully) fix documentation generation: readthedocs/readthedocs.org#4912 (comment)
* Added example code to config file * Added html context * Mirrored a setup on GitHub See: readthedocs/readthedocs.org#4912 (comment) * Fixed typo
It would be nice to be able to build docs for libraries managed with poetry.
maybe by checking for a
[tool.poetry]
section inpyproject.toml
, having to keep a separate requirements.txt file in sync feels a bit fragile.The text was updated successfully, but these errors were encountered: